Fixes: ConfigClientProperties#uri can't be set correctly as the ConfigClientProperties in BootstrapContext will be replaced #2623
Closed
519674304 wants to merge 1 commit intospring-cloud:mainfrom
Closed
Conversation
…e resolve properties so ConfigClientProperties should be fetched from ConfigServerInstanceMonitor
Contributor
|
This PR should be made against the 4.1.x branch. |
Author
Thanks, I will correct it. |
Contributor
|
Closing in favor of #2630 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every time org.springframework.cloud.config.client.ConfigServerConfigDataLocationResolver#resolveProfileSpecific be invoked, it will create a new ConfigClientProperties and replace the ConfigClientProperties in the BootstrapContext, but the ConfigClientProperties in the ConfigServerInstanceMonitor will be only set in the first time invoke.
Though, org.springframework.cloud.config.client.ConfigServerConfigDataLocationResolver#loadProperties will replace the org.springframework.cloud.config.client.ConfigClientProperties#uri if spring.cloud.config.discovery.enabled equals true, but the uri is get from the ConfigClientProperties from BootstrapContext which was replaced.