Only ignore profile activation and inclusion if the property source is profile specific#2613
Merged
ryanjbaxter merged 1 commit intospring-cloud:mainfrom Oct 31, 2024
Conversation
…s profile specific
Member
|
In practice, how does this affect the client app? |
Contributor
Author
|
What ends up happening is that if any of the property sources that come from the config server contains This could result in 2 bugs and I am sure there would be more....
|
Member
|
So should this go only in main then for the behavior change, or does it fix bugs that should go in 4.1.x? |
Contributor
Author
|
It would be a change in behavior but IMO its a change in behavior that is fixing a bug. Maybe we should talk with the rest of the team to see what they think? |
Member
|
yup, we can chat tomorrow |
ryanjbaxter
pushed a commit
that referenced
this pull request
Oct 31, 2024
…s profile specific (#2613)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we set the flag on all property sources (like we do currently) then any profiles that should be activated via
spring.profiles.activeorspring.profiles.includecoming from the config server will not be activated in the application.