Skip to content

Makes default-label in CredhubEnvironmentRepository configurable#2519

Merged
ryanjbaxter merged 2 commits intospring-cloud:4.1.xfrom
kvmw:kvmw/credhub-default-label
Sep 6, 2024
Merged

Makes default-label in CredhubEnvironmentRepository configurable#2519
ryanjbaxter merged 2 commits intospring-cloud:4.1.xfrom
kvmw:kvmw/credhub-default-label

Conversation

@kvmw
Copy link
Copy Markdown
Contributor

@kvmw kvmw commented Sep 6, 2024

the default-label in credhub backend should be configurable, similar to git, jdbc and other backends.

@ryanjbaxter
Copy link
Copy Markdown
Contributor

Can we add a note to the documentation about the property?

@ryanjbaxter ryanjbaxter added this to the 4.1.4 milestone Sep 6, 2024
@kvmw
Copy link
Copy Markdown
Contributor Author

kvmw commented Sep 6, 2024

Sure,
Just to confirm, the docs are the one in this repo under /docs folder.

@ryanjbaxter
Copy link
Copy Markdown
Contributor

ryanjbaxter commented Sep 6, 2024 via email

@kvmw
Copy link
Copy Markdown
Contributor Author

kvmw commented Sep 6, 2024

The second commits updates docs to include default label configuration.

@ryanjbaxter ryanjbaxter merged commit 96b5775 into spring-cloud:4.1.x Sep 6, 2024
@kvmw kvmw deleted the kvmw/credhub-default-label branch September 9, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants