Skip to content

Fixes the order of profiles and application names in CredhubEnvironmentRepository#2458

Merged
ryanjbaxter merged 1 commit intospring-cloud:4.1.xfrom
kvmw:kvmw/fix-order
Sep 3, 2024
Merged

Fixes the order of profiles and application names in CredhubEnvironmentRepository#2458
ryanjbaxter merged 1 commit intospring-cloud:4.1.xfrom
kvmw:kvmw/fix-order

Conversation

@kvmw
Copy link
Copy Markdown
Contributor

@kvmw kvmw commented Sep 3, 2024

The order of property sources created by CredhubEnvironmentRepository was not correct. They should have been reversed.

For a given profile string of p1,p2,p3 in configuration, the property source created for p3 should be the first in the list followed by p2, p1 and finally default profile.

The same order applies to application names.

@ryanjbaxter ryanjbaxter added this to the 4.1.4 milestone Sep 3, 2024
@ryanjbaxter ryanjbaxter merged commit fe6720d into spring-cloud:4.1.x Sep 3, 2024
@kvmw kvmw deleted the kvmw/fix-order branch October 17, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants