Thanks! Could you submit this against the 4.1.x branch and we can merge it forward?

@spencergibb what do you think about this change?

Also, In current implementation, If there are no secrets at all in CredHub an empty PropertySource will be added to the environment ( envrionment.propertySources will have one PropertySource which has no properties) . But this PR skips that and envrionment.propertySources will be empty. If this is not desired, I can add that empty ProperySource back.

That could be considered breaking, so I am not sure we want to make that change in 4.1.x. I guess we could do it in main.

Also, In current implementation, If there are no secrets at all in CredHub an empty PropertySource will be added to the environment ( envrionment.propertySources will have one PropertySource which has no properties) . But this PR skips that and envrionment.propertySources will be empty. If this is not desired, I can add that empty ProperySource back.

That could be considered breaking, so I am not sure we want to make that change in 4.1.x. I guess we could do it in main.

The second commit adds the main PropertySource, even if it is empty. The only caveat is the name of the PropertySource, in case application has more than one name. For example, given appOne,appTwo as application name in the current code, PropertySource name would be credhub-appOne,appTwo-myProfile-myLabel but the new code changes it to credhub-appOne-myProfile-myLabel.

Why change the property source name?

Why change the property source name?

PropertySource name has the following format: credhub-<APPLICATION-NAME>-<PROFILE>-<LABEL>.
Until now, because of this bug which I am trying to fix, for a given application name like appOne,appTwo we would have only one PropertySource which was named credhub-appOne,appTwo-default-master . But with the new changes we will have 2 property sources with the following names: credhub-appOne-default-master and credhub-appTwo-default-master. Assuming they are both empty, we just need to keep the first one.

Is this how other EnvironmentRepositories handle this situation as well?

If you mean splitting the application name, yes. In other repos application name is converted to an array and each individual item in array makes a separate property source.

If you are referring to empty property sources, no. not all of them. For example, Vault does not create empty property source.

Yes I was referring to the name, I just want to be as consistent as possible.

Yes I was referring to the name, I just want to be as consistent as possible.

JGit behaves the same.

a sample config like this:

spring:
  profiles:
    active: development,production
  application:
    name: cook,chef

will have the following property sources :

"configserver:https://github.com/cook-config/chef-production.properties"
"configserver:https://github.com/cook-config/cook-production.properties"
"configserver:https://github.com/cook-config/application-production.properties"
"configserver:https://github.com/cook-config/chef-development.properties"
"configserver:https://github.com/cook-config/cook-development.properties"
"configserver:https://github.com/cook-config/application-development.properties"
"configserver:https://github.com/cook-config/chef.properties"
"configserver:https://github.com/cook-config/cook.properties"
"configserver:https://github.com/cook-config/application.properties"