Skip to content

feat: resource charset support#2440

Merged
ryanjbaxter merged 1 commit intospring-cloud:mainfrom
klopfdreh:charsetsupport
Oct 4, 2024
Merged

feat: resource charset support#2440
ryanjbaxter merged 1 commit intospring-cloud:mainfrom
klopfdreh:charsetsupport

Conversation

@klopfdreh
Copy link
Copy Markdown
Contributor

@klopfdreh klopfdreh commented Jul 11, 2024

Fixes: #2115

Edit: In the web-view git shows the foo_enc.properties in a wrong way. In the IDE however it is encoded as intended. I added a hint in the .gitattributes so that UTF-8 is used. Lets see if the build is working and the fetch is using the proper encoding.

@klopfdreh klopfdreh force-pushed the charsetsupport branch 5 times, most recently from 311604e to e6d3860 Compare July 11, 2024 05:58
@ryanjbaxter
Copy link
Copy Markdown
Contributor

@klopfdreh could you add some documentation for this?

@klopfdreh
Copy link
Copy Markdown
Contributor Author

Sure 👍- beside the java doc where do I have to add it?

@ryanjbaxter
Copy link
Copy Markdown
Contributor

Somewhere in here. Not sure if you think there is a good spot to mention this new feature. Let me know what you think. We could add a new page as well.

@klopfdreh
Copy link
Copy Markdown
Contributor Author

I am going to add some documentation as soon as possible in this ticket.

Main reason for the feature is that if you use other characters not covered by UTF-8 you can configure the client that a given charset is set for requests and the server is reading and delivering the resource with that charset.

@ryanjbaxter
Copy link
Copy Markdown
Contributor

Thanks! It would be a good one to add to our 2024 release!

@klopfdreh klopfdreh changed the base branch from main to 4.1.x October 4, 2024 03:57
@klopfdreh
Copy link
Copy Markdown
Contributor Author

As I remember from the previous PR I provided 2024 is 4.1.x, so I changed the base of the PR to this branch.

I added some documentation into the ascii doc pages.

The file spring-cloud-config-server/src/test/resources/test/dev/foo_enc.properties is still not shown correctly in the GitHub UI, but the tests are working as expected with .gitattributes

Bildschirmfoto 2024-10-04 um 06 09 12

@ryanjbaxter ryanjbaxter changed the base branch from 4.1.x to main October 4, 2024 18:47
@ryanjbaxter
Copy link
Copy Markdown
Contributor

I want to keep this in main as it is new functionality.

@ryanjbaxter ryanjbaxter merged commit 9137286 into spring-cloud:main Oct 4, 2024
@klopfdreh
Copy link
Copy Markdown
Contributor Author

Thanks for merging this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resources can be stored and received with a given charset.

3 participants