Skip to content

Configures SshSessionFactory only if there is at least one git uri with ssh scheme#2287

Closed
kvmw wants to merge 1 commit intospring-cloud:mainfrom
kvmw:kvmw/fix-assertions
Closed

Configures SshSessionFactory only if there is at least one git uri with ssh scheme#2287
kvmw wants to merge 1 commit intospring-cloud:mainfrom
kvmw:kvmw/fix-assertions

Conversation

@kvmw
Copy link
Copy Markdown
Contributor

@kvmw kvmw commented Jun 14, 2023 •
edited
Loading

closes #2284

@kvmw kvmw mentioned this pull request Jun 14, 2023
Closed
@kvmw kvmw mentioned this pull request Jun 14, 2023
Merged
spencergibb
spencergibb requested changes Jun 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@spencergibb spencergibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we can't delete or rename public classes and there isn't going to be a major release to do that soon.

@kvmw kvmw force-pushed the kvmw/fix-assertions branch from 0c52d1c to 8da7452 Compare June 14, 2023 12:39
@kvmw kvmw marked this pull request as draft June 14, 2023 12:42
@kvmw kvmw force-pushed the kvmw/fix-assertions branch from 8da7452 to 0a86b4e Compare June 14, 2023 12:43
@kvmw kvmw marked this pull request as ready for review June 14, 2023 12:53
@kvmw kvmw requested a review from spencergibb June 14, 2023 12:53
@kvmw
Copy link
Copy Markdown
Contributor Author

kvmw commented Jun 14, 2023

Unfortunately, we can't delete or rename public classes and there isn't going to be a major release to do that soon.

Reverted those changes.

ryanjbaxter
ryanjbaxter approved these changes Jun 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ryanjbaxter ryanjbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only an issue in main, or is it also present in 3.1.x?

@kvmw
Copy link
Copy Markdown
Contributor Author

kvmw commented Jun 14, 2023

Is this only an issue in main, or is it also present in 3.1.x?

3.1.x has the same issue.

@ryanjbaxter
Copy link
Copy Markdown
Contributor

ryanjbaxter commented Jun 14, 2023

Can you submit this against 3.1.x and we can merge it forward?

@kvmw
Copy link
Copy Markdown
Contributor Author

kvmw commented Jun 14, 2023 •
edited
Loading

@ryanjbaxter
#2288 is ready. but the code is slightly different.

@ryanjbaxter
Copy link
Copy Markdown
Contributor

ryanjbaxter commented Jun 14, 2023

I merged things forward, I think I did it correct, but you might want to double check me ;)

@kvmw
Copy link
Copy Markdown
Contributor Author

kvmw commented Jun 15, 2023

@ryanjbaxter The merge looks fine. Just that @RunWith annotations are not needed in main branch.

PR: #2290

@kvmw kvmw deleted the kvmw/fix-assertions branch October 17, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanjbaxter ryanjbaxter ryanjbaxter approved these changes

@spencergibb spencergibb Awaiting requested review from spencergibb

Assignees

No one assigned

Labels

waiting for feedback

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

java.lang.AssertionError when using HTTP/HTTPS url for the git.uri with -enableassertions flag enabled.

4 participants

@kvmw @ryanjbaxter @spencergibb @spring-cloud-issues