Pass binder to ConfigServerInstanceProvider#2269
Merged
ryanjbaxter merged 1 commit into3.1.xfrom Jun 12, 2023
Merged
Conversation
This was referenced May 22, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we the config data loader loads configuration in two phases, the first phase does not allow us to load configuration from the BootstrapContext because we have not finished loading configuration data yet. Therefore it is useful to pass the Binder from the ResolverContext which contains the config data that has already been loaded in the first phase.
Related to changes made in #2260