Skip to content

restore useDefaultLabel parameter in ResourceController#1822

Merged
spencergibb merged 2 commits intospring-cloud:masterfrom
alftheo:feature/use-default-label
Mar 10, 2021
Merged

restore useDefaultLabel parameter in ResourceController#1822
spencergibb merged 2 commits intospring-cloud:masterfrom
alftheo:feature/use-default-label

Conversation

@alftheo
Copy link
Copy Markdown
Contributor

@alftheo alftheo commented Mar 3, 2021 •
edited
Loading

Add back the ability to retrieve text files without specifying a label, using the documented syntax
/{application}/{profile}/{path}?useDefaultLabel

@pivotal-issuemaster
Copy link
Copy Markdown

pivotal-issuemaster commented Mar 3, 2021

@alftheo Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@alftheo alftheo mentioned this pull request Mar 3, 2021
Closed
@pivotal-issuemaster
Copy link
Copy Markdown

pivotal-issuemaster commented Mar 3, 2021

@alftheo Thank you for signing the Contributor License Agreement!

@spencergibb
Copy link
Copy Markdown
Member

spencergibb commented Mar 3, 2021

Checkstyle failed. Can you update? You can build locally and see these errors.

[ERROR] /home/appuser/project/spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/resource/ResourceController.java:111: Line has leading space characters; indentation should be performed with tabs only. [RegexpSinglelineJava]
[ERROR] /home/appuser/project/spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/resource/ResourceController.java:111:35: ',' is not followed by whitespace. [WhitespaceAfter]
[ERROR] /home/appuser/project/spring-cloud-config-server/src/main/java/org/springframework/cloud/config/server/resource/ResourceController.java:180: Line has leading space characters; indentation should be performed with tabs only. [RegexpSinglelineJava]
[ERROR] /home/appuser/project/spring-cloud-config-server/src/test/java/org/springframework/cloud/config/server/resource/ResourceControllerIntegrationTests.java:23:8: Unused import - org.junit.Ignore. [UnusedImports]

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 3, 2021 •
edited
Loading

Codecov Report

Merging #1822 (8a50c55) into master (a2792ac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1822   +/-   ##
=========================================
  Coverage     77.32%   77.33%           
- Complexity     1283     1285    +2     
=========================================
  Files           163      163           
  Lines          4759     4761    +2     
  Branches        645      645           
=========================================
+ Hits           3680     3682    +2     
  Misses          829      829           
  Partials        250      250
Impacted Files Coverage Δ Complexity Δ
...oud/config/server/resource/ResourceController.java 80.00% <100.00%> (+0.63%) 21.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2792ac...8a50c55. Read the comment docs.

@alftheo
Copy link
Copy Markdown
Contributor Author

alftheo commented Mar 3, 2021

updated with checkstyle compliance.

@spencergibb spencergibb added this to the 3.0.3 milestone Mar 10, 2021
@spencergibb spencergibb merged commit dcf35c6 into spring-cloud:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

task

Projects

None yet

Milestone

3.0.3

Development

Successfully merging this pull request may close these issues.

4 participants

@alftheo @pivotal-issuemaster @spencergibb @spring-cloud-issues