Remove ResourceController mappings with param useDefaultLabel#1728
Remove ResourceController mappings with param useDefaultLabel#1728spencergibb merged 1 commit intospring-cloud:masterfrom ThomasVitale:gh-1643
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1728 +/- ##
============================================
+ Coverage 77.33% 77.35% +0.02%
+ Complexity 1252 1251 -1
============================================
Files 160 160
Lines 4610 4606 -4
Branches 615 615
============================================
- Hits 3565 3563 -2
+ Misses 808 806 -2
Partials 237 237
Continue to review full report at Codecov.
|
|
@ThomasVitale However it was a very useful function. How can I now fetch plain text from "default label" when config client is not aware of label name? |
|
Hi, Actually I used this function a lot in older spring version, but now wanted also to use this #1417. Looks like after upgrading to version that includes this feature, I'd like to serve a plain text with encryption from default branch that the client is now aware of. |
|
I created myself a controller with requestmapping and that works fine. Can we add that into the project? |
|
@alftheo please open a new issue |
|
I've created a new issue #1823 with an attached pull request. Let me know if something is missing bad or wrong |
ResourceControllerhas multiple@RequestMappingsthat would conflict. Currently, to avoid passing the label, we use theuseDefaultLabelrequest parameter to select. Using that parameter to select a different @RequestMapping doesn't work. The two mappings using the parameter have been removed now.Fixes gh-1643