Skip to content

support multiple spring application names for Vault Fixes gh-1356#1379

Merged
ryanjbaxter merged 1 commit intomasterfrom
fix/multi-app-names-vault
May 15, 2019
Merged

support multiple spring application names for Vault Fixes gh-1356#1379
ryanjbaxter merged 1 commit intomasterfrom
fix/multi-app-names-vault

Conversation

@Haybu
Copy link
Copy Markdown
Contributor

@Haybu Haybu commented May 11, 2019

Fixes gh-1356

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2019

Codecov Report

Merging #1379 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1379      +/-   ##
============================================
+ Coverage     78.34%   78.38%   +0.03%     
- Complexity     1016     1017       +1     
============================================
  Files           123      123              
  Lines          3658     3660       +2     
  Branches        518      519       +1     
============================================
+ Hits           2866     2869       +3     
+ Misses          611      610       -1     
  Partials        181      181
Impacted Files Coverage Δ Complexity Δ
...server/environment/VaultEnvironmentRepository.java 76.25% <100%> (+0.6%) 16 <0> (+1) ⬆️
...cloud/config/monitor/FileMonitorConfiguration.java 52.38% <0%> (+0.79%) 21% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b99631...04e1d22. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2019

Codecov Report

Merging #1379 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1379      +/-   ##
============================================
+ Coverage     78.34%   78.38%   +0.03%     
- Complexity     1016     1017       +1     
============================================
  Files           123      123              
  Lines          3658     3660       +2     
  Branches        518      519       +1     
============================================
+ Hits           2866     2869       +3     
+ Misses          611      610       -1     
  Partials        181      181
Impacted Files Coverage Δ Complexity Δ
...server/environment/VaultEnvironmentRepository.java 76.25% <100%> (+0.6%) 16 <0> (+1) ⬆️
...cloud/config/monitor/FileMonitorConfiguration.java 52.38% <0%> (+0.79%) 21% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b99631...04e1d22. Read the comment docs.

@ryanjbaxter ryanjbaxter merged commit dc1992e into master May 15, 2019
@ryanjbaxter
Copy link
Copy Markdown
Contributor

I cherry picked the fix to the 2.0.x branch and merged it forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple spring application name for Vault

4 participants