Describe the bug
I'm using Spring Boot 3.1.4 and Spring Cloud 2022.0.4.
I've configured Spring Cloud Config to use discovery-first. I've put the spring.config.import=configserver: statement in a sub-document of application.properties, activated using spring.config.activate.on-profile=!noconfigserver. I also have a some-profile profile active.
When fetching the some-profile config, the service discovery is used; however, it also fetches the non-profile-specific config without using service discovery. This fails.
Sample
application.properties:
spring.application.name=demo
spring.cloud.config.uri=http://not-discovery:8888/
spring.cloud.config.discovery.enabled=true
spring.cloud.config.discovery.service-id=configuration-service
eureka.client.service-url.default-zone=http://eurekahost:8761
spring.profiles.active=some-profile
#---
spring.config.activate.on-profile=!noconfigserver
spring.config.import=configserver:
pom.xml:
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>3.1.4</version>
<relativePath /> <!-- lookup parent from repository -->
</parent>
<groupId>com.example</groupId>
<artifactId>spring-config-discovery-first-bug</artifactId>
<version>0.0.1-SNAPSHOT</version>
<name>spring-config-discovery-first-bug</name>
<description>Demo project for Spring Config bug</description>
<properties>
<java.version>21</java.version>
<spring-cloud.version>2022.0.4</spring-cloud.version>
</properties>
<dependencies>
<dependency>
<groupId>org.springframework.cloud</groupId>
<artifactId>spring-cloud-starter-config</artifactId>
</dependency>
<dependency>
<groupId>org.springframework.cloud</groupId>
<artifactId>spring-cloud-starter-netflix-eureka-client</artifactId>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-test</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-web</artifactId>
</dependency>
</dependencies>
<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.springframework.cloud</groupId>
<artifactId>spring-cloud-dependencies</artifactId>
<version>${spring-cloud.version}</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>
<build>
<plugins>
<plugin>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-maven-plugin</artifactId>
</plugin>
</plugins>
</build>
</project>The following logs are from using a configuration server registered at 127.0.0.1, and adding a not-discovery entry to my hosts file, also pointing at 127.0.0.1 (added for the sake of getting these logs):
2023-10-17T11:59:46.656+01:00 INFO 24856 --- [demo] [ main] SpringConfigDiscoveryFirstBugApplication : The following 1 profile is active: "some-profile"
2023-10-17T11:59:46.675+01:00 INFO 24856 --- [demo] [ main] o.s.c.c.c.ConfigServerConfigDataLoader : Fetching config from server at : http://127.0.0.1:8888/
2023-10-17T11:59:46.675+01:00 INFO 24856 --- [demo] [ main] o.s.c.c.c.ConfigServerConfigDataLoader : Located environment: name=demo, profiles=[some-profile], label=null, version=63f3e2b6bd303329ef841d18f99585a5dcef1449, state=null
2023-10-17T11:59:46.675+01:00 INFO 24856 --- [demo] [ main] o.s.c.c.c.ConfigServerConfigDataLoader : Fetching config from server at : http://not-discovery:8888/
2023-10-17T11:59:46.675+01:00 INFO 24856 --- [demo] [ main] o.s.c.c.c.ConfigServerConfigDataLoader : Located environment: name=demo, profiles=[default], label=null, version=63f3e2b6bd303329ef841d18f99585a5dcef1449, state=null
You can see that it fetches config for the default profile being active from http://not-discovery:8888/.
This does not happen without the spring.config.activate.on-profile property. I think the issue is that the bootstrapConfigClientProperties in ConfigServerConfigDataLocationResolver.loadProperties have not been initialised by the ConfigServerInstanceMonitor yet when it comes to create the ConfigClientProperties for the non-profile-specific import, because that only happens when the import is processed, and the import is not processed before profile activation.
Describe the bug
I'm using Spring Boot 3.1.4 and Spring Cloud 2022.0.4.
I've configured Spring Cloud Config to use discovery-first. I've put the
spring.config.import=configserver:statement in a sub-document of application.properties, activated usingspring.config.activate.on-profile=!noconfigserver. I also have asome-profileprofile active.When fetching the
some-profileconfig, the service discovery is used; however, it also fetches the non-profile-specific config without using service discovery. This fails.Sample
application.properties:
pom.xml:
The following logs are from using a configuration server registered at 127.0.0.1, and adding a
not-discoveryentry to my hosts file, also pointing at 127.0.0.1 (added for the sake of getting these logs):You can see that it fetches config for the
defaultprofile being active fromhttp://not-discovery:8888/.This does not happen without the
spring.config.activate.on-profileproperty. I think the issue is that the bootstrapConfigClientProperties in ConfigServerConfigDataLocationResolver.loadProperties have not been initialised by the ConfigServerInstanceMonitor yet when it comes to create theConfigClientPropertiesfor the non-profile-specific import, because that only happens when the import is processed, and the import is not processed before profile activation.