add some basic tests #1559
Merged
add some basic tests #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wind57 <[email protected]>
wind57
commented
Aug 18, 2025
| * @author Olga Maciaszek-Sharma | ||
| */ | ||
| @SpringBootTest(classes = CachingServiceInstanceListSupplierTests.TestConfig.class) | ||
| @SpringBootTest(classes = CachingServiceInstanceListSupplierTests.TestConfig.class, properties = { |
Contributor
Author
There was a problem hiding this comment.
minor refactor here, nothing has changes logically.
Signed-off-by: wind57 <[email protected]>
wind57
commented
Aug 18, 2025
| /** | ||
| * @author wind57 | ||
| */ | ||
| class CaffeineBasedLoadBalancerCacheManagerTests { |
Contributor
Author
There was a problem hiding this comment.
I'm trying to get to the bottom of another ticket (spring-cloud/spring-cloud-kubernetes#1970) and this is why I ended up here, trying to figure out the code a bit more.
Signed-off-by: wind57 <[email protected]>
Contributor
Author
|
@ryanjbaxter minor thing if you want to look at. thank you |
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Contributor
|
Looks good, want to make it Ready To Review so I can merge it? |
Contributor
Author
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.