Add application listener to locate property sources during bootstrap#1228
Merged
ryanjbaxter merged 3 commits intospring-cloud:3.1.xfrom May 4, 2023
Conversation
Contributor
Author
|
Partial fix for spring-cloud/spring-cloud-config#1922 |
Contributor
Author
ryanjbaxter
force-pushed
the
run-bootstrap-propertysource-locators-during-bootstrap
branch
from
45c6e71 to
1fa3b25
Compare
Also adds support for activating profiles using spring.profiles.active from bootstrap property source listeners. Allow profiles to be passed from bootstrap context to main application context
ryanjbaxter
force-pushed
the
run-bootstrap-propertysource-locators-during-bootstrap
branch
from
1fa3b25 to
296453f
Compare
spencergibb
approved these changes
May 3, 2023
Also adds support for activating profiles using spring.profiles.active from bootstrap property source listeners. Allow profiles to be passed from bootstrap context to main application context Updating version in docs
… of github.com:ryanjbaxter/spring-cloud-commons into run-bootstrap-propertysource-locators-during-bootstrap
qnnn
reviewed
Aug 4, 2024
| // environment. This allows any profiles activated during bootstrap to be | ||
| // activated when | ||
| // config data runs in the main application context. | ||
| environment.setActiveProfiles(context.getEnvironment().getActiveProfiles()); |
Contributor
There was a problem hiding this comment.
@ryanjbaxter Is it possible to bind configurations like spring.main and spring.banner within this code segment? These configurations work when loaded through ConfigDataEnvironmentPostProcessor, but they do not take effect when loaded through BootstrapApplicationListener. It appears that the issue might be because PropertySourceBootstrapConfiguration is actually executed in the main context's initializer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds support for activating profiles using spring.profiles.active from bootstrap property source listeners.