Please add a test

@spencergibb I pushed some unit tests.

Any updates on this @spencergibb ?

bump @spencergibb

@OlgaMaciaszek Are you able to help me out here? This PR has been open for a while.

Thanks, @sruffatti. Will review it shortly.

Hi @sruffatti, thanks for submitting the PR. Makes sense. There are some minor style issues. I have added comments - please address them. Also, could you please file this against 3.1.x instead of main? It'll be considered a bugfix, so we'd like for it to also be included in the 2021.0.x release train.

@OlgaMaciaszek I addressed your comments. Are you asking me to change the target branch to 3.1.x instead main? When I do that I see many commits included in the PR. Are you asking me to branch off 3.1.x, add my changes, and then open a PR?

Hi @sruffatti,

@OlgaMaciaszek I addressed your comments. Are you asking me to change the target branch to 3.1.x instead main? When I do that I see many commits included in the PR. Are you asking me to branch off 3.1.x, add my changes, and then open a PR?

The second approach will probably be faster and easier, so it's a good idea.

@OlgaMaciaszek I created another PR merging to 3.1.x here #1239

Closing in favour of #1239.