Fixes #202 issue.#203
Merged
ryanjbaxter merged 2 commits intospring-cloud:mainfrom Jul 29, 2024
Merged
Conversation
ryanjbaxter
reviewed
Jul 28, 2024
| timeLimiterRegistry, Optional.ofNullable(circuitBreakerCustomizers.get(id)), isDisableTimeLimiter); | ||
| } | ||
|
|
||
| private boolean isDisableTimeLimiter() { |
Contributor
There was a problem hiding this comment.
This method is no longer used right? Maybe we can keep it and call the new Util method or just remove it
Author
There was a problem hiding this comment.
yes, it's not used. It was private, so just I removed it.
ryanjbaxter
requested changes
Jul 28, 2024
Contributor
ryanjbaxter
left a comment
ryanjbaxter
left a comment
There was a problem hiding this comment.
Can you add some documentation on the new properties and behavior?
Author
|
Please review the changes. Thanks for feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review this.