This repository was archived by the owner on Dec 9, 2025. It is now read-only.
Changing support for baggage context to actually make child span in t… #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he context instead of parent when using withSpan.
Contributor
|
We don't have a test for this change really - nothing changed in the tests except for the setup. Can we add a test that would fail without this change? |
Contributor
Author
|
@marcingrzejszczak I've added the test for given situation. |
Contributor
Author
|
@marcingrzejszczak Do i need to add something else ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he context instead of parent when using withSpan.
Fixes: #156