Upgrade Scio to 0.14.12; run CI on Java 17; use magnolify-bigquery in BigDiffy#784
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #784 +/- ##
==========================================
+ Coverage 70.61% 70.68% +0.06%
==========================================
Files 44 44
Lines 1865 1859 -6
Branches 309 315 +6
==========================================
- Hits 1317 1314 -3
+ Misses 548 545 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
|
thanks @clairemcginty! I tested your changes with BigSampler and BigDiffy. Both succeeded, and the changes look good to me. TY! |
Contributor
|
also tested with BigQuery in BigSampler here, also successful! |
Contributor
Author
amazing, thanks Ben! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaOptions.scalafile, which adds options required for 17+). Note that the project still has the-target 8scalaOpt so it will continue to produce Java8-compatible bytecodeBigQueryTypeusage in BigDiffy with magnolify-bigquery. BigQueryType is deprecated and less performant than Magnolify for BQ writesTesting: Packaged locally and tested BigDiffy with BQ output to validate that all three tables (
_fields,_global, and_keys) are produced correctly.