Upgrade to Scio 0.14.0#696
Merged
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #696 +/- ##
==========================================
+ Coverage 71.24% 71.32% +0.08%
==========================================
Files 40 40
Lines 1749 1747 -2
Branches 259 247 -12
==========================================
Hits 1246 1246
+ Misses 503 501 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2 tasks
RustedBones
reviewed
Jan 26, 2024
Comment on lines
+161
to
+162
| "com.google.guava" % "guava" % guavaVersion, | ||
| "org.apache.beam" % "beam-vendor-guava-32_1_2-jre" % beamVendorVersion, |
There was a problem hiding this comment.
I don't think common should depend on beam. It is fine to use non shaded guava IMHO
clairemcginty
marked this pull request as ready for review
February 1, 2024 13:42
Member
|
Thanks for the update @clairemcginty @RustedBones! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scio 0.14.0 upgrade