Skip to content

Update scala ecosystem#688

Merged
catherinejelder merged 6 commits into
masterfrom
update-scala-ecosystem
Nov 22, 2023
Merged

Update scala ecosystem#688
catherinejelder merged 6 commits into
masterfrom
update-scala-ecosystem

Conversation

@RustedBones

@RustedBones RustedBones commented Nov 22, 2023 •
edited
Loading

Copy link
Copy Markdown
  • update sbt
  • cleanup deprecated java options
  • update plugins
    • remove scalastye
    • replace sbt-ptotobuf wit sbt-protoc
    • update sbt-avro
    • add sbt-scalafmt
    • update other plugins
  • update scala version
  • cleanup dependencies
    • remove slf4j-simple logger implementation from compile scope
    • move test deps to test scope
  • fork tests to avoid class loading issue
  • move generated test files in test scope
  • update CI
    • update resource class to avoid job killed
    • update CI image to non deprecated openjdk 11
    • enforce formatting

@codecov

codecov Bot commented Nov 22, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b7278e9) 71.40% compared to head (82a70c9) 71.24%.

Files Patch % Lines
...in/scala/com/spotify/ratatool/diffy/BigDiffy.scala 75.00% 1 Missing ⚠️
...main/scala/com/spotify/ratatool/io/ParquetIO.scala 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
- Coverage   71.40%   71.24%   -0.17%     
==========================================
  Files          40       40              
  Lines        1710     1749      +39     
  Branches      140      254     +114     
==========================================
+ Hits         1221     1246      +25     
- Misses        489      503      +14
Flag Coverage Δ
ratatoolCli 2.99% <0.00%> (-0.08%) ⬇️
ratatoolCommon ∅ <ø> (?)
ratatoolDiffy 31.42% <54.54%> (+0.61%) ⬆️
ratatoolExamples 15.91% <0.00%> (-0.04%) ⬇️
ratatoolSampling 62.26% <85.71%> (-0.33%) ⬇️
ratatoolScalacheck 81.71% <ø> (+0.03%) ⬆️
ratatoolShapeless 4.31% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@catherinejelder
catherinejelder merged commit 46adba7 into master Nov 22, 2023
@catherinejelder
catherinejelder deleted the update-scala-ecosystem branch November 22, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@catherinejelder catherinejelder catherinejelder approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RustedBones @catherinejelder