Fixed task hang up in shellInternal due to unread error pipe.#230
Merged
polac24 merged 2 commits intoNov 22, 2023
Merged
Conversation
grigorye
marked this pull request as draft
November 20, 2023 14:02
grigorye
force-pushed
the
bug/shell-hangup-due-to-unread-pipe
branch
from
November 20, 2023 14:42
4330b9b to
0290557
Compare
polac24
reviewed
Nov 21, 2023
Co-authored-by: Bartosz Polaczyk <[email protected]>
polac24
approved these changes
Nov 22, 2023
polac24
left a comment
polac24
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! If you want to land it, make it a PR and we can merge it.
grigorye
marked this pull request as ready for review
November 22, 2023 11:55
Contributor
Author
Thanks, yeah, fixing this thing may help to avoid encountering the hangup in further iterations, if any. |
Collaborator
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address #229.