cleanup: remove redundant implementations of getDetectorClassName() (#3352)

gtoison · web-flow · commit 4b0cfffc634b · 2025-03-11T22:06:05.000-04:00
diff --git a/spotbugs-tests/src/test/java/edu/umd/cs/findbugs/JUnitDetectorAdapter.java b/spotbugs-tests/src/test/java/edu/umd/cs/findbugs/JUnitDetectorAdapter.java
@@ -77,16 +77,6 @@ public void finishTest() throws Exception {
     public void finishPass() {
     }
 
-    /*
-     * (non-Javadoc)
-     *
-     * @see edu.umd.cs.findbugs.Detector2#getDetectorClassName()
-     */
-    @Override
-    public String getDetectorClassName() {
-        return this.getClass().getName();
-    }
-
     /*
      * (non-Javadoc)
      *
diff --git a/spotbugs/src/main/java/edu/umd/cs/findbugs/DetectorToDetector2Adapter.java b/spotbugs/src/main/java/edu/umd/cs/findbugs/DetectorToDetector2Adapter.java
@@ -78,14 +78,4 @@ public void visitClass(ClassDescriptor classDescriptor) throws CheckedAnalysisEx
             profiler.end(detector.getClass());
         }
     }
-
-    /*
-     * (non-Javadoc)
-     *
-     * @see edu.umd.cs.findbugs.Detector2#getDetectorClassName()
-     */
-    @Override
-    public String getDetectorClassName() {
-        return detector.getClass().getName();
-    }
 }
diff --git a/spotbugs/src/main/java/edu/umd/cs/findbugs/asm/ClassNodeDetector.java b/spotbugs/src/main/java/edu/umd/cs/findbugs/asm/ClassNodeDetector.java
@@ -52,11 +52,6 @@ protected ClassNodeDetector(BugReporter bugReporter) {
         this.bugReporter = bugReporter;
     }
 
-    @Override
-    public String getDetectorClassName() {
-        return this.getClass().getName();
-    }
-
     @Override
     public void visitClass(ClassDescriptor classDescriptor) throws CheckedAnalysisException {
 
diff --git a/spotbugs/src/main/java/edu/umd/cs/findbugs/bcel/CFGDetector.java b/spotbugs/src/main/java/edu/umd/cs/findbugs/bcel/CFGDetector.java
@@ -48,16 +48,6 @@ public abstract class CFGDetector implements Detector2 {
     public void finishPass() {
     }
 
-    /*
-     * (non-Javadoc)
-     *
-     * @see edu.umd.cs.findbugs.Detector2#getDetectorClassName()
-     */
-    @Override
-    public String getDetectorClassName() {
-        return getClass().getName();
-    }
-
     protected ClassContext classContext;
     protected Method method;
 
diff --git a/spotbugs/src/main/java/edu/umd/cs/findbugs/detect/BuildObligationPolicyDatabase.java b/spotbugs/src/main/java/edu/umd/cs/findbugs/detect/BuildObligationPolicyDatabase.java
@@ -282,11 +282,6 @@ public void finishPass() {
         }
     }
 
-    @Override
-    public String getDetectorClassName() {
-        return this.getClass().getName();
-    }
-
     private void addBuiltInPolicies() {
 
         // Add the database entries describing methods that add and delete
diff --git a/spotbugs/src/main/java/edu/umd/cs/findbugs/detect/CheckExpectedWarnings.java b/spotbugs/src/main/java/edu/umd/cs/findbugs/detect/CheckExpectedWarnings.java
@@ -407,10 +407,4 @@ public void finishPass() {
         }
 
     }
-
-    @Override
-    public String getDetectorClassName() {
-        return CheckExpectedWarnings.class.getName();
-    }
-
 }
diff --git a/spotbugs/src/main/java/edu/umd/cs/findbugs/detect/TestDataflowAnalysis.java b/spotbugs/src/main/java/edu/umd/cs/findbugs/detect/TestDataflowAnalysis.java
@@ -69,16 +69,6 @@ public TestDataflowAnalysis(BugReporter bugReporter) {
     public void finishPass() {
     }
 
-    /*
-     * (non-Javadoc)
-     *
-     * @see edu.umd.cs.findbugs.Detector2#getDetectorClassName()
-     */
-    @Override
-    public String getDetectorClassName() {
-        return getClass().getName();
-    }
-
     /*
      * (non-Javadoc)
      *

Original file line number	Diff line number	Diff line change
`@@ -78,14 +78,4 @@ public void visitClass(ClassDescriptor classDescriptor) throws CheckedAnalysisEx`
`78`	`78`	`profiler.end(detector.getClass());`
`79`	`79`	`}`
`80`	`80`	`}`
`81`		`-`
`82`		`- /*`
`83`		`- * (non-Javadoc)`
`84`		`- *`
`85`		`- * @see edu.umd.cs.findbugs.Detector2#getDetectorClassName()`
`86`		`- */`
`87`		`- @Override`
`88`		`- public String getDetectorClassName() {`
`89`		`- return detector.getClass().getName();`
`90`		`- }`
`91`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -282,11 +282,6 @@ public void finishPass() {`
`282`	`282`	`}`
`283`	`283`	`}`
`284`	`284`
`285`		`- @Override`
`286`		`- public String getDetectorClassName() {`
`287`		`- return this.getClass().getName();`
`288`		`- }`
`289`		`-`
`290`	`285`	`private void addBuiltInPolicies() {`
`291`	`286`
`292`	`287`	`// Add the database entries describing methods that add and delete`
Original file line number	Diff line number	Diff line change
`@@ -407,10 +407,4 @@ public void finishPass() {`
`407`	`407`	`}`
`408`	`408`
`409`	`409`	`}`
`410`		`-`
`411`		`- @Override`
`412`		`- public String getDetectorClassName() {`
`413`		`- return CheckExpectedWarnings.class.getName();`
`414`		`- }`
`415`		`-`
`416`	`410`	`}`