Add Prometheus metrics to MemoryManager#518
Merged
Conversation
gruuya
approved these changes
Apr 23, 2024
Cargo.toml
Outdated
| tokio-graceful-shutdown = { version = "0.14" } | ||
| tonic = { version = "0.10.0", optional = true } | ||
| tower = { version = "0.4", optional = true } | ||
| tower = { version = "0.4" } |
mildbyte
force-pushed
the
feature/memory-manager-observability
branch
from
213dbae to
5445458
Compare
|
|
||
| impl Metrics { | ||
| pub fn new() -> Self { | ||
| describe_gauge!( |
Collaborator
There was a problem hiding this comment.
I'm late to the party, but should this be describe_counter rather than describe_gauge? Ditto in L24
Contributor
Author
There was a problem hiding this comment.
Oh, that's actually a good catch - these are used as counters below and not gauges, though for some reason they still show up in the metrics output as type counter.
$ curl localhost:9191/metrics | grep memo | grep TYPE
# TYPE seafowl_datafusion_memory_pool_allocated_bytes_total counter
# TYPE seafowl_datafusion_memory_pool_freed_bytes_total counter
# TYPE seafowl_datafusion_memory_pool_reserved_bytes_current gauge
Cowboy-pushed 2755bb8 to fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the metrics feature non-optional (there's a lot of code coming that exposes metrics and it'll get painful/pointless to maintain the ability to opt out of compiling metrics support at the cargo feature level
Add a special
MemoryPoolthat wraps the default DataFusionMemoryPool(that setting defaults toGreedyMemoryPool, so construct that explicitly) and logs the total allocated/released bytes by each DataFusion query tree node.Also replace all uses of
RwLock<HashMap>toDashMapas @gruuya proposed.Sample output: