Conversation
mildbyte
approved these changes
Jan 4, 2024
| // Ensure that our TTL parameter is honored, so that we don't get a frozen cache after it | ||
| // gets filled up once. | ||
| let _ = tokio::time::sleep(Duration::from_secs(1)).await; | ||
| let _ = tokio::time::sleep(Duration::from_millis(1100)).await; |
Contributor
There was a problem hiding this comment.
1.1s and not 1s? (funny I was complaining about sleep in tests in the previous PR and had it in my code to begin with)
Contributor
Author
There was a problem hiding this comment.
Oh, the previous sleep was put there by me (also 1s now leads to non-consistent results, sometimes a couple of entries get vacated and sometimes none at all)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also bump the other deps (moka, wasm, etc.)