Repository navigation
Use proper federation in max_timestamp_df during acceleration refresh - #7055
Merged
Merged
Conversation
Contributor
✅ Pull with Spice PassedPassing checks:
|
max_timestamp_df during acceleration refresh
krinart
marked this pull request as ready for review
September 8, 2025 23:17
krinart
marked this pull request as draft
September 9, 2025 22:02
krinart
marked this pull request as ready for review
September 10, 2025 00:55
sgrebnov
previously approved these changes
Sep 10, 2025
phillipleblanc
previously approved these changes
Sep 10, 2025
Co-authored-by: Phillip LeBlanc <[email protected]>
krinart
dismissed stale reviews from phillipleblanc and sgrebnov
via
September 10, 2025 16:03
fe5a473
krinart
enabled auto-merge
September 10, 2025 16:04
sgrebnov
approved these changes
Sep 10, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 15, 2025
…on refresh (#7055)" (#7156) This reverts commit f3b127e. Co-authored-by: Luke Kim <[email protected]>
This was referenced Sep 16, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Sep 20, 2025
…mp + integration tests (#7228) * Revert "Revert "Use proper federation in `max_timestamp_df` during acceleration refresh (#7055)" (#7156)" This reverts commit 068edc6. * Add unit tests for acceleration refresh * Add full refresh tests * Fix lint * Fix lint * Fix lint * Address comments * Address comments * Fix * Fix * Fix lint * Fix lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6908
The way we currently initilize dataframe in
max_timestamp_dfresults in a fullTableScan(see original ticket for more details)In order to fix this we can downcast
acceleratortoPolyTableProvider, and then extract federated table source.After doing this I ran into an issue with casting timestamp to
TIMESTAMPin sqlite, which was addressed here spiceai/datafusion#99 - hence updated datafusion dependencies