Adding missing patched commits to spiceai-48#95
Merged
kczimm merged 2 commits intospiceai-48-oldfrom Aug 22, 2025
Merged
Conversation
Author
|
After adding #87, I get this test error: failures:
---- dataframe::filtered_aggr_with_param_values stdout ----
Error: SchemaError(FieldNotFound { field: Column { relation: Some(Bare { table: "table1" }), name: "c2" }, valid_fields: [Column { relation: None, name: "count(table1.c2) FILTER (WHERE table1.c3 > $1)" }] }, Some(""))
failures:
dataframe::filtered_aggr_with_param_values |
UPSTREAM NOTE: This has not been submitted upstream yet.
kczimm
force-pushed
the
kczimm/prep-spiceai-48
branch
from
8b42c31 to
90cd47f
Compare
Author
|
Fixed and amended commit. Moving on to cherry picking #88 |
Author
|
After adding #88 and resolving merge conflicts, I get this test error: Error: Context("Can not find type of table1.c3 needed to infer placeholder type", SchemaError(FieldNotFound { field: Column { relation: Some(Bare { table: "table1" }), name: "c3" }, valid_fields: [Column { relation: None, name: "count(table1.c2) FILTER (WHERE table1.c3 > $1)" }] }, Some("")))
test dataframe::filtered_aggr_with_param_values ... FAILED
failures:
failures:
dataframe::filtered_aggr_with_param_valueswhich is similar to before |
…pes based on their expression (#88) UPSTREAM NOTE: This has not been submitted upstream yet.
kczimm
force-pushed
the
kczimm/prep-spiceai-48
branch
from
3797c45 to
7a95436
Compare
Author
|
Had to modify this new function to fix the broken test. I'm not 100% confident in it but tests pass now: fn find_first_non_null_data_type_expr_placeholder<'a>(
exprs: impl Iterator<Item = &'a Expr>,
schema: &DFSchema,
) -> Result<DataType> {
let mut failed_expr = None;
for expr in exprs {
let data_type = match expr.get_type(schema) {
Ok(dt) => dt,
Err(e) => {
failed_expr = Some((expr, e));
continue;
}
};
if data_type != DataType::Null {
return Ok(data_type);
}
}
if let Some((expr, e)) = failed_expr {
return Err(e.context(format!(
"Can not find type of {expr} needed to infer placeholder type"
)));
}
Ok(DataType::Null)
}
|
sgrebnov
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding:
infer_placeholder_typesto infer all possible placeholder types based on their expression #88