Skip casting to binary when inner expr is value#60
Merged
Sevenannn merged 2 commits intospiceai-43from Nov 13, 2024
Merged
Conversation
sgrebnov
approved these changes
Nov 13, 2024
Jeadie
reviewed
Nov 13, 2024
Co-authored-by: Jack Eadie <[email protected]>
This was referenced Nov 13, 2024
Merged
Sevenannn
added a commit
that referenced
this pull request
Nov 14, 2024
* Skip casting to binary when inner expr is value * Update datafusion/sql/src/unparser/expr.rs Co-authored-by: Jack Eadie <[email protected]> --------- Co-authored-by: Jack Eadie <[email protected]>
Sevenannn
added a commit
that referenced
this pull request
Nov 21, 2024
* Skip casting to binary when inner expr is value (#60) * Skip casting to binary when inner expr is value * Update datafusion/sql/src/unparser/expr.rs Co-authored-by: Jack Eadie <[email protected]> --------- Co-authored-by: Jack Eadie <[email protected]> * Fix binary view cast (#63) * fix * Fix clippy error --------- Co-authored-by: Jack Eadie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Datafusion enforces an eager cast of value to binary value in the logical plan where a comparison with binary value is presented. For example, in the following plan
Filter: value = CAST(Utf8("binary_value") AS BinaryHowever, when using unparser to convert the plan back to sql, where the sql will be sent to various query engine (e.g. DuckDB). the cast is not needed for the value, in the example above the value "binary_value", since the raw value can be directly used in SQL engines without casting to an engine specific dictionary type. Therefore, the plan can simply be rewritten into
where value = 'binary_value'
What changes are included in this PR?
cast_to_sql, which directly pass inner_expr instead of cast inner_expr when casting to binary / dictionary in the Expr::Cast, and keep the original casting logic in all other cases.Are these changes tested?
Yes