Merge unparsing improvements from Datafusion main branch#48
Merged
sgrebnov merged 7 commits intospiceai-42from Oct 24, 2024
Merged
Merge unparsing improvements from Datafusion main branch#48sgrebnov merged 7 commits intospiceai-42from
sgrebnov merged 7 commits intospiceai-42from
Conversation
* unparse the projection base on the source schema * refactor and enhance the test
* unparse Sort with push down limit * cargo fmt * set query limit directly
* change pub function comment to doc * unparse subquery alias without projections * fix tests * rollback the empty line * rollback the empty line * exclude the table_scan with pushdown case * fmt and clippy * simplify the ast to string and remove unused debug code
peasee
approved these changes
Oct 24, 2024
phillipleblanc
approved these changes
Oct 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Merge recent unparsing improvements from datafusion master branch.
This is to simplify adding incremental improvements and to avoid fixing recently resolved issues.