Support unparsing plans with both Aggregation and Window functions#35
Support unparsing plans with both Aggregation and Window functions#35sgrebnov merged 1 commit intospiceai-42from
Conversation
|
This is an improvement for the following PR that added Window functions unparsing support: There is the following comment. TPCDS queries contain such cases, this PR addressed them
|
…pache#12705) * Support unparsing plans with both Aggregation and Window functions (#35) * Fix unparsing for aggregation grouping sets * Add test for grouping set unparsing * Update datafusion/sql/src/unparser/utils.rs Co-authored-by: Jax Liu <[email protected]> * Update datafusion/sql/src/unparser/utils.rs Co-authored-by: Jax Liu <[email protected]> * Update * More tests --------- Co-authored-by: Jax Liu <[email protected]>
* dissallow pushdown of volatile PhysicalExprs * fix * add FilteredVec helper to handle filter / remap pattern (#34) * checkpoint: Address PR feedback in https://github.com/apach... * add FilteredVec to consolidate handling of filter / remap pattern * lint * Add slt test for pushing volatile predicates down (#35) --------- Co-authored-by: Andrew Lamb <[email protected]>
Which issue does this PR close?
Improve unparsing to support queries containing simultaneously Aggregation and Window functions. Existing version fails with error
Tried to unproject agg expr not found in provided Aggregate!This makes unparsing to correctly handle TPC-DS Q47, Q53, Q57, Q63, Q89
Query Q47: