Add dialect param to use CHAR instead of TEXT for Utf8 unparsing for MySQL#12
Merged
sgrebnov merged 2 commits intospiceai-39from Jul 13, 2024
Merged
Add dialect param to use CHAR instead of TEXT for Utf8 unparsing for MySQL#12sgrebnov merged 2 commits intospiceai-39from
sgrebnov merged 2 commits intospiceai-39from
Conversation
use_char_for_utf8_cast Dialect paramuse_char_for_utf8_cast Dialect param (MySQL string literals cast fix)
use_char_for_utf8_cast Dialect param (MySQL string literals cast fix)
digadeesh
approved these changes
Jul 12, 2024
d5be971 to
d594e1b
Compare
Sevenannn
approved these changes
Jul 12, 2024
d594e1b to
107c02a
Compare
phillipleblanc
approved these changes
Jul 13, 2024
phillipleblanc
pushed a commit
that referenced
this pull request
Jul 15, 2024
sgrebnov
added a commit
that referenced
this pull request
Jul 16, 2024
sgrebnov
added a commit
that referenced
this pull request
Jul 16, 2024
Sevenannn
pushed a commit
that referenced
this pull request
Jul 18, 2024
* Add dialect param to use CHAR instead of TEXT for Utf8 unparsing for MySQL (#12) * Configurable data type instead of flag for Utf8 unparsing * Fix type in comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes spiceai/spiceai#1948
Rationale for this change
MySQL cast function does not support
TEXTand requiresCHAR(automatically returns VARCHAR, TEXT, LONGTEXT)Example query:
Before this change (fails in MySQL)
After this change (works in MySQL)