Conversation
More consistent with noxfile.py
Also, call out to a script to do this task, to keep noxfile from getting too complicated.
This is to accomodate for "default" themes
We'll add them manually one-by-one since sphinx-themes seems really bad.
- Breakup _build_theme and inline calls into render_themes - Allow for better error handling - Blacken code
Also lets me get rid of that annoying options key that wasn't being used.
This shouldn't happen online, but is for development
Hopefully, I don't break things in the process.
The upload-artifact step is slow.
I'm likely not going to be the primary maintainer so it's perfectly OK to not include this CoC which has me listed as a point of contact.
pradyunsg
force-pushed
the
revamp-entire-website
branch
from
7d439a2 to
6e35df3
Compare
|
👍 IMHO A single-column layout (for large screens) would work better. |
|
I tried that locally yesterday, but it didn't look right to me on a 15" laptop screen or on my 34" monitor. Having a single column means that all the width goes towards to making the images bigger, something that I didn't feel was worthwhile given that it's possible to get a good idea for how a theme looks even at half width and if you really need a closer look, there's a preview link available. :) |
|
Well, dont need to use 100% of the screen width. Anyway, just my 2 cents. Thanks for great work. |
|
@shirou Nudge. |
|
ah, sorry for late response. OK. let's merge this. but I want to replace the current website after adding themes as much as possible. Thank you for your great contribution!! |
|
Whee! Thanks @shirou! ^>^ I'll add the additional sites in a few follow up PRs! Thanks for the push access here. :) |
4 participants
Closes #17
This brings in the changes from https://github.com/pradyunsg/sphinx-themes/ into this project, replacing the entire existing project tree with that repository. Notable changes to that repository since last discussion:
conf.pyfiles are included and linked-to from the galleryPost-merge tasks for maintainers/admins:
Notably, this PR technically has fewer themes than
master, but I say we add them in a follow up because... well, I'd like to do the "add-the-themes" task later and leave a bit of space for others to pick up some of the themes as well. :)