[MRG][FIX] Remove output box from print(__doc__) #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @lucyleeow |
Member
|
Nice! |
lesteve
reviewed
Aug 9, 2019
| output = sg.execute_code_block( | ||
| compiler, code_block, example_globals, script_vars, gallery_conf | ||
| ) | ||
| assert output.isspace() == True |
Member
There was a problem hiding this comment.
Very minor comment: you don't need the == True here.
Contributor
Author
There was a problem hiding this comment.
Yes I realised this later - but excused myself as 'making it easier to read'? (:/) Too late now I guess?
Member
There was a problem hiding this comment.
I pushed a commit directly in master so we can sleep better at night ;-).
Contributor
|
Good job @lucyleeow ! You're starting to own this project :). Next level: review PRs. You can for instance start with #523 |
Contributor
Author
|
:-o |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #528
Prevents output box if
captured_std.isspace().Test to ensure
execute_code_blockdoes not generate a code block forprint(__doc__).(also tested locally on plot_kernal_pca.py and does not produce the output box)