MNT Add test for minigallery_sort_order#1402
Merged
lucyleeow merged 3 commits intosphinx-gallery:masterfrom Nov 8, 2024
Merged
MNT Add test for minigallery_sort_order#1402lucyleeow merged 3 commits intosphinx-gallery:masterfrom
minigallery_sort_order#1402lucyleeow merged 3 commits intosphinx-gallery:masterfrom
Conversation
drammock
reviewed
Nov 7, 2024
Member
drammock
left a comment
drammock
left a comment
There was a problem hiding this comment.
LGTM other than the one comment
sphinx_gallery/utils.py
Outdated
| "plot_1.py", | ||
| ] | ||
| return ORDER.index(Path(file).name) | ||
| return file |
Member
There was a problem hiding this comment.
cruft
Suggested change
| return file |
Contributor
Author
There was a problem hiding this comment.
Thank you, that was a github co-pilot addition and I didn't realise it was added. 🤦
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on after #1391
Adds check that callable works for
minigallery_sort_orderNote I had to import the custom sort function as I needed to build (and not just
create_sphinx_app) and thus could not define function in config file as it is not it is not pickle-able (for in new sphinx)