Allow to disable writing computation times#1385
Merged
larsoner merged 3 commits intosphinx-gallery:masterfrom Oct 7, 2024
Merged
Allow to disable writing computation times#1385larsoner merged 3 commits intosphinx-gallery:masterfrom
larsoner merged 3 commits intosphinx-gallery:masterfrom
Conversation
Contributor
|
Makes sense to me, can you add it to the configuration doc somewhere? |
to allow for reproducible builds. Default to not write durations. if SOURCE_DATE_EPOCH indicates that a reproducible build is wanted. Helps with pygraphviz/pygraphviz#541 See https://reproducible-builds.org/ for why this matters.
Author
|
I added some docs. Feel free to adjust it as you like. |
drammock
reviewed
Oct 4, 2024
doc/configuration.rst
Outdated
| Write computation times | ||
| ======================= | ||
|
|
||
| Set to ``false`` if you want to omit computation times from the output. |
Member
There was a problem hiding this comment.
Suggested change
| Set to ``false`` if you want to omit computation times from the output. | |
| Set to ``False`` if you want to omit computation times from the output. |
Co-authored-by: Lucy Liu <[email protected]> Co-authored-by: Daniel McCloy <[email protected]>
bmwiedemann
added a commit
to bmwiedemann/pygraphviz
that referenced
this pull request
Oct 14, 2024
MridulS
pushed a commit
to pygraphviz/pygraphviz
that referenced
this pull request
Oct 17, 2024
Fixes #541 together with sphinx-gallery/sphinx-gallery#1385
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow to disable writing computation times to allow for reproducible builds.
Default to not write durations. if SOURCE_DATE_EPOCH indicates that a reproducible build is wanted.
Helps with pygraphviz/pygraphviz#541