allow call script as pkg entry#1268
Merged
larsoner merged 2 commits intosphinx-gallery:masterfrom Mar 11, 2024
Merged
Conversation
Contributor
|
Agreed this is a better approach, and hopefully not too hard to adopt for people that had previously been using the scripts (which was probably rare in the first place) so I think safe enough to merge without a deprecation cycle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These additional scripts are quite uneasy to handle and maintain; I would suggest calling it from the package directly, and the one with copy drop with 1:1 explanation in docs (as if you try to call the copy shell command, it messes with your local env while development)
ref: https://stackoverflow.com/a/782984/4521646
would simplify work on #1267 -> https://setuptools.pypa.io/en/latest/userguide/entry_point.html
cc: @lucyleeow