Conversation
|
Highlights:
@lucyleeow feel free to merge if you're happy! |
lucyleeow
left a comment
lucyleeow
left a comment
There was a problem hiding this comment.
Thank you for doing this, I'm not well versed in CI but it seems much cleaner. Just some nits.
.github/workflows/tests.yml
Outdated
| sphinx_version: '6' | ||
| distrib: mamba | ||
| - os: ubuntu-latest | ||
| python: '3.8' |
There was a problem hiding this comment.
I assume 3.8 is the min python version we support? Not essential, but is it easy to make this a variable? Makes it easier to update and maybe easier to find/more explicit what our min support python version is.
There was a problem hiding this comment.
but is it easy to make this a variable?
You mean in YAML? Not super easy. I think it's not too bad to find it here. I'll just update developers.rst to mention this alongside "latest Python" in the release instructions/reminders.
.github/workflows/tests.yml
Outdated
| locale: C | ||
| - os: ubuntu-latest | ||
| python: '3.11' | ||
| sphinx_version: '6' |
There was a problem hiding this comment.
Just a question, why do want to test this sphinx version?
There was a problem hiding this comment.
Really just to try to hit all supported major Sphinx versions but I'll make it clearer
Should we add a note to our release documentation to check if there is a new python release? I don't like relying on my memory to do things. |
|
Thank you! |
2 participants
Long-overdue migration to GitHub Actions. Should help with maintainability and stuff like #1213 (comment)