BUG: Fix bug with orphan sg_api_usage#1207
Conversation
|
This one should be ready to go @lucyleeow ! |
lucyleeow
left a comment
lucyleeow
left a comment
There was a problem hiding this comment.
LGTM, thanks! Just one question.
| user=sphinx-gallery | ||
| add-sections={"api":{"prefix":"**API changes**","labels":["api"]},"documentation":{"prefix":"**Documentation**","labels":["documentation"]},"maintenance":{"prefix": "**Project maintenance**","labels":["maintenance"]}} | ||
| max-issues=200 | ||
| max-issues=2 |
There was a problem hiding this comment.
Why do we only want to fetch 2 issues? We should want a few months worth right?
There was a problem hiding this comment.
We actually already have issues=no meaning "don't put any issues . It's a mystery to me why it even bothers fetching issues when this is the case but it did (at least at some point).
There was a problem hiding this comment.
Ah right, did not realise. So for the changelog we only use PRs? I thought we, at some point, used issues as well?
There was a problem hiding this comment.
Yes we used to but in practice they didn't seem to add much value compared to properly listing PRs so I removed them
There was a problem hiding this comment.
Good to know, I tend to agree. Some issues are just quickly resolved without anything needing to be done and thus did not really add anything to the changelog.
2 participants
Fixes this bug when running in noplot mode:
The
:orphan:and title should always be added.Also snuck in some
changelog_generatorstuff to speed things up that I've been using elsewhere that should help at release time.