Skip to content

ENH: Improve API usage graph#1203

Merged
larsoner merged 3 commits intosphinx-gallery:masterfrom
larsoner:api_usage
Sep 27, 2023
Merged

ENH: Improve API usage graph#1203
larsoner merged 3 commits intosphinx-gallery:masterfrom
larsoner:api_usage

Conversation

@larsoner
Copy link
Copy Markdown
Contributor

After working on mne-tools/mne-python#12013 (comment) I wanted to port over some changes that I think will be generally helpful. After some simplifications and tweaks to the diagram to make it more readable, esp. with a dense layout with overlaps, this is what I see:

before after
SG image image
MNE image image

@drammock feel free to test out locally (PATTERN=no_examples make html-pattern in MNE or make html in doc of this repo) and tweak if you want to try changing stuff.

@drammock
Copy link
Copy Markdown
Member

I don't really have time to tweak/test right now. This is already a big improvement, thanks! My only feedback is that the black text on the dark reddish color is too low-contrast, so I'd tweak that red color to be lighter

@larsoner
Copy link
Copy Markdown
Contributor Author

Switched to the Figure 13 colormap and reduced the alpha (88 vs AA) and I think it's more readable now:

image

I'll push and mark for merge-when-green, thanks for the quick feedback @drammock !

@larsoner larsoner enabled auto-merge (squash) September 27, 2023 15:55
@larsoner larsoner merged commit f9df31a into sphinx-gallery:master Sep 27, 2023
@larsoner larsoner deleted the api_usage branch September 27, 2023 16:11
clrpackages referenced this pull request in clearlinux-pkgs/pypi-sphinx_gallery Nov 28, 2023
… to version 0.15.0

v0.15.0
-------

Support for Python 3.7 dropped in this release. Requirement is now Python >=3.8.
Pillow added as a dependency.

**Implemented enhancements:**

-  ENH: Improve logging visibility of errors and filenames `#1225 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1225>`__ (`larsoner <https://github.com/larsoner>`__)
-  ENH: Improve API usage graph `#1203 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1203>`__ (`larsoner <https://github.com/larsoner>`__)
-  ENH: Always write sg_execution_times and make DataTable `#1198 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1198>`__ (`larsoner <https://github.com/larsoner>`__)
-  ENH: Write all computation times `#1197 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1197>`__ (`larsoner <https://github.com/larsoner>`__)
-  ENH: Support source files in any language `#1192 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1192>`__ (`speth <https://github.com/speth>`__)
-  FEA Add examples recommender system `#1125 <https://github.com/sphinx-gallery/sphinx-gallery/pull/1125>`__ (`ArturoAmorQ <https://github.com/ArturoAmorQ>`__)

(NEWS truncated at 15 lines)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants