MAINT Remove unused parametrize in test_figure_rst_srcset#1172
Merged
larsoner merged 5 commits intosphinx-gallery:masterfrom Aug 18, 2023
Merged
MAINT Remove unused parametrize in test_figure_rst_srcset#1172larsoner merged 5 commits intosphinx-gallery:masterfrom
test_figure_rst_srcset#1172larsoner merged 5 commits intosphinx-gallery:masterfrom
Conversation
larsoner
reviewed
Aug 17, 2023
sphinx_gallery/directives.py
Outdated
| return srcset | ||
|
|
||
|
|
||
| def _copy_images(self, node): |
Contributor
There was a problem hiding this comment.
Can you move this back down to minimize the diff? It helps with git blame
Contributor
Author
There was a problem hiding this comment.
Yeah diff is ugly, I'll revert.
lucyleeow
changed the title
directives.pytest_figure_rst_srcset
Contributor
Author
|
I think the removal of unused functions was done in #1169 , I might have done that by mistake since lint doesn't pass if we don't remove. This now just fixes the test. |
Contributor
|
Thanks @lucyleeow ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes unused parametrization in
test_figure_rst_srcset, and move private funcs to above their use.Originally
visit_srcset_otherwas here to check adding other builders see: #808 (comment), but not used so removed here.