MAINT: Replace build_sphinx with sphinx-build#1139
Merged
larsoner merged 1 commit intosphinx-gallery:masterfrom May 15, 2023
Merged
MAINT: Replace build_sphinx with sphinx-build#1139larsoner merged 1 commit intosphinx-gallery:masterfrom
larsoner merged 1 commit intosphinx-gallery:masterfrom
Conversation
oscargus
force-pushed
the
sphinxbuild
branch
4 times, most recently
from
e6d2049 to
6bb16ea
Compare
oscargus
changed the title
lucyleeow
reviewed
May 15, 2023
Contributor
lucyleeow
left a comment
lucyleeow
left a comment
There was a problem hiding this comment.
Thanks for the fix, just a few questions
Contributor
For posterity: sphinx-doc/sphinx#9595 |
lucyleeow
reviewed
May 15, 2023
Contributor
|
Thanks @oscargus , and @lucyleeow ignore my ping from the other PR, sorry I wasn't following properly! 🤦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Sphinx 7.0.1 support for build_sphinx was removed. I think this is the way to go.
Also installs
imageioas I think that is not an expected failure...Edit:
install. Also, sphinx-dev addsabsl-pyfor Sphinx-dev test?hash(?)to href-link so removed the closing " from the test.