Skip to content

C, C++: fundamental type parsing #9918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakobandersen merged 4 commits into from
Dec 5, 2021
Merged

C, C++: fundamental type parsing #9918

jakobandersen merged 4 commits into from
Dec 5, 2021

Conversation

@jakobandersen
Copy link
Contributor

@jakobandersen jakobandersen commented Nov 30, 2021

Feature or Bugfix

  • Bugfix

Purpose

Fixes #9917 and breathe-doc/breathe#771.

Note primarily for @tk0miya: I put this in 4.3.x so it could go out immediately, and it indeed causes a crash in Breathe (because it messes with C++ internals) if users have the "wrong" order in non-type template parameters.

@jakobandersen
C++, fix typo in internal function
355147e
@jakobandersen
C++, fix parsing of fundamental types
67d6734 
When multiple simple type specifiers are part of the type,
then they may appear in any order.
@jakobandersen
C, fix parsing of fundamental types
c09643c 
When multiple simple type specifiers are part of the type,
then they may appear in any order.
@jakobandersen jakobandersen added this to the 4.3.2 milestone Nov 30, 2021
@jakobandersen jakobandersen self-assigned this Nov 30, 2021
@tk0miya
Copy link
Member

tk0miya commented Dec 4, 2021

Okay, I'll release a new package after this PR merged.

@jakobandersen
Copy link
Contributor Author

jakobandersen commented Dec 4, 2021

@marxin, do you by chance have time to double check with the GCC docs that this didn't break anything? or do you have instructions for how I compile them in the current state?

@jakobandersen
Copy link
Contributor Author

jakobandersen commented Dec 5, 2021

Okay, I'll release a new package after this PR merged.

@tk0miya, please go ahead with a release as it fits in your schedule. I'll just rebase this if it doesn't make it in time.

@marxin
Copy link
Contributor

marxin commented Dec 5, 2021

@marxin, do you by chance have time to double check with the GCC docs that this didn't break anything? or do you have instructions for how I compile them in the current state?

Please try that yourself:

git clone https://github.com/marxin/texi2rst-generated
cd texi2rst-generated/sphinx
make html

@jakobandersen
Copy link
Contributor Author

jakobandersen commented Dec 5, 2021

Please try that yourself:

Thanks! No breakages found. Merging.

@jakobandersen jakobandersen merged commit 3ae124f into sphinx-doc:4.3.x Dec 5, 2021
@jakobandersen jakobandersen deleted the c-cpp-fundamental-type-permutation branch December 5, 2021 10:34
@jakobandersen jakobandersen mentioned this pull request Dec 5, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tk0miya tk0miya tk0miya approved these changes

Assignees

@jakobandersen jakobandersen

Labels

domains:c domains:cpp type:bug

Projects

None yet

Milestone

4.3.2

Development

Successfully merging this pull request may close these issues.

3 participants

@jakobandersen @tk0miya @marxin