autodoc: Avoid updating __annotations__ with parent class members #13935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13934
This commit ensures that the
__annotations__dict of a class is updated only with type comment-derived annotations for direct members; the type comment-derived annotations for parent classes are added to those parent classes own__annotations__dicts. The inherited member annotations are still found bytyping.get_type_hints.This commit also improves the efficiency of incorporating the annotations found by the ModuleAnalyzer. Previously, each call to _load_object_by_name for a data member or attribute would result in separately iterating over all attributes (including within classes) found by ModuleAnalyzer for the containing module, and in the case of classes, the containing modules of all parent classes. For modules with many members this cost could likely be significant. With this commit, at least for the purpose of updating
__annotations__dicts, each module's attributes only processed a single time in total.