Fix intersphinx reftitle for non-numeric versions #13737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes 'v' prefix from non-numeric versions in reftitles in intersphinx. Appending it resulted in strange version names like "vstable" instead of just "stable" Signed-off-by: Szymon Karpiński <[email protected]>
Signed-off-by: Szymon Karpiński <[email protected]>
AA-Turner
requested changes
Jul 19, 2025
sphinx/ext/intersphinx/_resolve.py
Outdated
Comment on lines
53
to
54
| version = 'v%s' % inv_item.project_version | ||
| reftitle = _('(in %s %s)') % (inv_item.project_name, version) |
Member
There was a problem hiding this comment.
Please can you use an f-string here?
Contributor
Author
There was a problem hiding this comment.
Changed to f-string for version = .... For reftitle = ... I can't use an f-string, because as far as I understand _(...) needs to work on a yet unformatted string.
Signed-off-by: Szymon Karpiński <[email protected]>
AA-Turner
approved these changes
Jul 19, 2025
Member
AA-Turner
left a comment
AA-Turner
left a comment
There was a problem hiding this comment.
Thanks! Please add yourself to AUTHORS and add a brief CHANGES entry.
A
Member
|
Congratulations on your first contribution @szkarpinski! A |
AA-Turner
added
extensions:intersphinx
sprint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR removes 'v' prefix from non-numeric versions in reftitles in intersphinx. Appending it resulted in strange version names like "vstable" instead of just "stable".
References