Avoid redundant target-version#12250
Closed
DimitriPapadopoulos wants to merge 1 commit intosphinx-doc:masterfrom
Closed
Avoid redundant target-version#12250DimitriPapadopoulos wants to merge 1 commit intosphinx-doc:masterfrom
DimitriPapadopoulos wants to merge 1 commit intosphinx-doc:masterfrom
Conversation
Do not specify the minimal Python version with `target-version`. Instead, let ruff read `requires-python` in `pyproject.toml`.
DimitriPapadopoulos
changed the title
Contributor
Author
|
Just noticed it is flagged by repo-review:
|
Contributor
Author
|
Unfortunately, there's a gap between theory and practice: I presume ruff may not read |
Contributor
Author
|
astral-sh/ruff#10299 already raised this ruff issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject: Avoid redundant target-version
Feature or Bugfix
Purpose
target-version. Instead, let ruff readrequires-pythoninpyproject.toml.