Support string methods on path objects#11619
Merged
AA-Turner merged 3 commits intosphinx-doc:masterfrom Aug 23, 2023
Merged
Conversation
Member
|
I personally think that path objects should be used whenever possible. IIRC there has been some work in CPython to improve pathlib performances, e.g., by implementing some operations in C. As such, it sould be better in the long term to switch now and inform users as much as possible that treating them as strings is deprecated. Since we made the changes and some upstream repos may have already switched, it's maybe better not to revert (if we eventually plan to completely drop str aupport in some future version). |
stephenfin
approved these changes
Aug 23, 2023
Contributor
stephenfin
left a comment
stephenfin
left a comment
There was a problem hiding this comment.
This is a total hack and I approve 👍 Let's get this out and drop it in 8.x as you suggest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @stephenfin @tronical @picnixz @lucyleeow
xref: #11605
This PR would allow using
strmethods on paths (e.g.app.outdir.rstrip(...)). It is however very fragile.The alternative would be to entirely revert pathlib support, but I fear downstream may have already adapted to expect usage of
pathlib.Pathobjects.Thoughts appreciated.
A