Repository navigation
Fix signature of docutils include_source monkeypatch - #11610
Merged
Merged
Conversation
The docutils method's second argument is called 'source', not 'path'
1 task done
Member
|
This will be in 7.2.2 |
AA-Turner
pushed a commit
that referenced
this pull request
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docutils
insert_inputmethod's second argument is called 'source', not 'path'Feature or Bugfix
Purpose
The monkeypatching of docutils broke the matplotlib
plotdirective, which callsinsert_inputand passes thesourceparameter by name.This PR simply matches the signature of the monkeypatch to that of the upstream method such that calling methods are not affected.
Relates
includedirective #11510