linkcheck builder: begin using session-based HTTP requests#11503
linkcheck builder: begin using session-based HTTP requests#11503AA-Turner merged 10 commits intosphinx-doc:masterfrom jayaddison:issue-11324/linkcheck-sessioned-requests
Conversation
…flake8 style guidance
|
Should we rewrite the existing get and head in terms of a session? This is how A |
|
It's probably a good idea to re-use the same code paths for both methods.. my rationale when duplicating the implementations was to avoid modifying any non-linkcheck-builder code. I'll take another look into consolidating them into shared implementations. |
|
What do you think of the approach in b7d7fcf ? |
…TTP request method parameters
…equest method arguments Partially reverts commit 31fec32.
|
I've pushed a commit to only implement the lower-level A |
Nice - yep, that looks much better to me 👍 |
|
Thanks @jayaddison -- this is the culmination of quite a bit of preparatory work, thank you for driving this all through! A |
|
Thank you very much @AA-Turner :) You're welcome. I'll follow along with the next release to listen for user feedback. |
Feature or Bugfix
Purpose
Detail
Relates
linkcheckbuilder.