Skip to content

test_intl: resolve test flakiness by using integer nanosecond timestamps during file modification detection#11435

Merged
AA-Turner merged 9 commits intosphinx-doc:masterfrom
jayaddison:issue-11232/flaky-gettext-test-fixup
Jul 20, 2023
Merged

test_intl: resolve test flakiness by using integer nanosecond timestamps during file modification detection#11435
AA-Turner merged 9 commits intosphinx-doc:masterfrom
jayaddison:issue-11232/flaky-gettext-test-fixup

Conversation

@jayaddison
Copy link
Copy Markdown
Contributor

@jayaddison jayaddison commented May 21, 2023

Feature or Bugfix

  • Bugfix

Purpose

Detail

  • The flaky test assertions relate to the detection of modified files during application builds; and it seems to be message catalog files (.mo) that are relevant.
  • Timestamp detection had been using floating-point seconds-since-the-epoch.
  • Based on a small sample size of testing from jayaddison/sphinx#3, I believe that integer-based nanoseconds-since-the-epoch may be more reliable (but I'm not 100% confident).
  • At the same time, revert commit 718993a that I believe should be unnecessary -- and maybe-cause-related -- simplifying the code and retrieving the current-time as nanoseconds-since-epoch.

Relates

@picnixz

This comment was marked as outdated.

Sign in to view
@jayaddison

This comment was marked as outdated.

Sign in to view
@picnixz

This comment was marked as outdated.

Sign in to view
@jayaddison

This comment was marked as outdated.

Sign in to view
@picnixz

This comment was marked as outdated.

Sign in to view
@jayaddison

This comment was marked as outdated.

Sign in to view
@picnixz

This comment was marked as outdated.

Sign in to view
@jayaddison jayaddison mentioned this pull request May 22, 2023
Closed
@jayaddison

This comment was marked as outdated.

Sign in to view
AA-Turner
AA-Turner reviewed Jul 20, 2023
View reviewed changes
Comment thread sphinx/environment/__init__.py
@AA-Turner AA-Turner merged commit ecc8613 into sphinx-doc:master Jul 20, 2023
@AA-Turner
Copy link
Copy Markdown
Member

AA-Turner commented Jul 20, 2023

Thanks @jayaddison!

A

@AA-Turner
Copy link
Copy Markdown
Member

AA-Turner commented Jul 20, 2023

https://github.com/sphinx-doc/sphinx/actions/runs/5615685910/job/15216466568

A test failure on test_gettext_dont_rebuild_mo...

FAILED tests/test_intl.py::test_gettext_dont_rebuild_mo - AssertionError: assert 1 == 0
 +  where 1 = <function test_gettext_dont_rebuild_mo.<locals>.get_number_of_update_targets at 0x0000020DF2DD83C0>(<SphinxTestApp buildername='dummy'>)
= 1 failed, 1821 passed, 23 skipped, 5 xfailed, 28 xpassed in 212.44s (0:03:32) =

@jayaddison jayaddison mentioned this pull request Jul 22, 2023
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 20, 2023
@jayaddison jayaddison deleted the issue-11232/flaky-gettext-test-fixup branch September 14, 2023 13:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AA-Turner AA-Turner AA-Turner left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Seemingly random CI failures of tests/test_intl.py::test_gettext_dont_rebuild_mo with Windows

3 participants

@jayaddison @picnixz @AA-Turner