Skip to content

linkcheck tests: use thread-safe collections.deque for client header recording#11350

Closed
jayaddison wants to merge 2 commits intosphinx-doc:masterfrom
jayaddison:issue-11348/flaky-test-linkcheck-client-header-collection
Closed

linkcheck tests: use thread-safe collections.deque for client header recording#11350
jayaddison wants to merge 2 commits intosphinx-doc:masterfrom
jayaddison:issue-11348/flaky-test-linkcheck-client-header-collection

Conversation

@jayaddison
Copy link
Copy Markdown
Contributor

Feature or Bugfix

  • Bugfix

Purpose

  • When threaded test HTTP servers are in use, as in linkcheck builder: begin using session-based HTTP requests #11340, then client header related tests have been failing intermittently.
  • This pull request attempts to address that by using a thread-safe collection that is shared between the unit test (object owner) and server handler (object recipient/producer thread).

Detail

  • collections.deque is thread-safe and supports append and iteration, similar to the list object currently in-use.
  • Tested as part of jayaddison/sphinx#2.

Relates

@jayaddison
Copy link
Copy Markdown
Contributor Author

(please hold-off on merging until after the 6.2.0 release)

@jayaddison
Copy link
Copy Markdown
Contributor Author

This does not seem like it'll provide a fix for #11348; see discussion in that issue for details.

@jayaddison jayaddison closed this Apr 26, 2023
@jayaddison jayaddison deleted the issue-11348/flaky-test-linkcheck-client-header-collection branch April 26, 2023 16:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky unit test: test_auth_header_uses_first_match

1 participant