linkcheck builder: ensure error response is removed-from-scope before fallback request #11349
linkcheck builder: ensure error response is removed-from-scope before fallback request #11349jayaddison wants to merge 1 commit intosphinx-doc:masterfrom jayaddison:issue-11299/flaky-test-isolate-linkcheck-response-scope
Conversation
…n initial HTTP HEAD request is out-of-scope before performing a fallback HTTP GET request (ensuring that the associated 'response' object's resources can be collected) (cherry picked from commit d6f29be)
|
(please hold-off on merging until after the 6.2.0 release) |
|
I'm undecided about whether this is a valid fix. It is included in #11340 currently, where linkchecker unit test failures continue to occur. I'll move this into draft status. |
|
I don't believe that the change here is required, so I'm going to close this and drop the relevant commits while rebasing #11340. |
jayaddison
deleted the
issue-11299/flaky-test-isolate-linkcheck-response-scope
branch
|
My best-effort attempt to explain why I think this may have been useful is that I'm not convinced that client-side resources (particularly, connections and sockets) are being closed and returned to the Although I don't think that an unused variable continuing to exist within the scope of a method should make a semantic difference, I felt that by explicitly removing it from scope using I don't feel like I've proven or disproven that, though - and so it seems better not to include the change at all. |
1 participant
Feature or Bugfix
Purpose
Detail
Relates